Silverstripe 5 compatibility #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Put some work into this today. Managed to get the yarn build working again, but decided to stop (for today) with this upgrade. Good thing: Everything is ready to work on the front-end fixes for SS5 compatibility. |
|
@rskuipers did some commit with lots of fixes for front-end. Known bugs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
I've started working on SS5 compatibility for the elemental grid.
Decided to create a draft PR with my progress.
If I don't have time to finish this PR, I hope this PR will help you getting further if you are going to work on the SS5 compatibility.
What I've done yet;
Known issues/to-do
Front-end; silverstripe/silverstripe-elemental#1032
Because of the API breaks in SS5 and Elemental 5, there needs to be an mayor release for this module to make it SS5 compatible.